Repository navigation
Reject incomplete OPFS transfers in the synchronous store - #66
Merged
Merged
Conversation
FileSystemSyncAccessHandle.read() and write() return the number of bytes actually transferred, which the File System standard allows to be lower than requested. OpfsSyncObjectStore ignored it: a short write was truncated/extended to the payload length and reported as stored, so that the runtime released the object from memory while its file held partial data; a short read returned a buffer partly filled with zeros. put() now writes the remaining bytes in turn and throws when a write transfers nothing, before recording the size, so that the existing spill rollback keeps the object resident; get() reads in turn and throws when the file cannot be read up to its size. Assisted-by: Claude Opus 5.5
Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up of the updated review of the develop branches (R1, remainder of A02).
FileSystemSyncAccessHandle.read()/write()return the number of bytes actually transferred, which the File System standard allows to be lower than requested.OpfsSyncObjectStoreignored it:put()now writes the remaining bytes in turn and throws when a write transfers nothing, before recording the size: the existing spill rollback (persistOrRestore) then keeps the object resident.get()reads in turn and throws when the file cannot be read up to its size.Tests