Repository navigation
Pin the Sigima 1.4 development snapshot (pixel-center convention) - #67
Merged
Merged
Conversation
… and grids) Point the development snapshot at the Sigima 1.4 follow-up branch, which locates image pixels by their centers in ROIs, grids, image centers and exact transformations, keeps complex values in resampling, and selects circle and polygon ROI pixels by their centers. The radial profile "center" mode now gives the center of the pixel grid: 23.5 and 31.5 for a 48 x 64 image whose pixel centers go from 0 to 47 and 0 to 63, instead of 24 and 32 (half a pixel off). The test expectation is updated accordingly. Assisted-by: Claude Opus 5.5
Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up of the updated review of the develop branches (R4): prepare the Sigima 1.4 upgrade through the existing
developmentRefmechanism.developmentRef→ Sigima6c9255a(head of Complex resampling, ROI grid partition and pixel-center masks for circles and polygons Sigima#84, stacked on the merged pixel-center convention, Locate image pixels by their centers in ROIs and transformations Sigima#83). The commit stays reachable once that PR is merged with a merge commit; the pin will be moved to the merge commit or replaced by the published 1.4.0 requirement.test_radial_profile_callback_recomputes_centre: the "center" mode now gives the center of the pixel grid, 23.5 and 31.5 for a 48 × 64 image whose pixel centers go from 0 to 47 and 0 to 63 (previously 24 and 32, half a pixel off). This is the only Python test affected by the new Sigima: ROI masks and grids changes leave the other 529 tests unchanged.npm run release:guardblocks a release while the snapshot is active, as expected: Sigima 1.4.0 must be published and pinned first.Tests
dependencyConfig,sigimaDependency): passed.Merge after DataLab-Platform/Sigima#84.