Repository navigation
Follow Sigima: image profiles in physical coordinates - #70
Merged
Merged
Conversation
Sigima now defines line, segment, average and radial profiles in physical coordinates (renamed parameters, contracts version 2): - the profile dialog exchanges physical coordinates with its shape and draws its preview on the Sigima pixel centers (non-uniform included); - the cross-section "Extract" buttons pass the physical coordinates of the pixel under the cursor; - tests use the new parameter names; the families reference checks are data-driven and the Desktop reference file is updated; - changelog. Refs #68 Assisted-by: Claude Opus 5.5
Refs #68 Assisted-by: Claude Opus 5.5
The Sigima snapshot declares the ROI pixel convention in the execution context of image computations: pin DataLab-Capsule to the development commit recording it (DataLab-Platform/DataLab-Capsule#4), since 0.1.0 does not and refuses such replays. The e2e families test now expects activities recorded with an older contract version to be refused. Refs #68 Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68
Summary
Follows DataLab-Platform/Sigima#98 (image profiles in physical coordinates, contracts v2) and pins
sigima-dependency.jsonto its merge commit (3af8228).ProfileDefinitionDialog.tsx): parameters are physical coordinates (y/x,x1/y1/x2/y2); no more pixel ⇄ index conversion. The dialog's own heatmap is drawn on the Sigima pixel centers (x0= center of the first pixel,xcoords/ycoordsfor non-uniform images), so that the shape matches the computation exactly. Line/segment points beyond the image are brought back to the outermost pixel centers; undefined average bounds stand for the image edges.src/utils/pixelCenters.ts).Note: the main image viewer draws pixels with
x0as the upper-left corner, half a pixel off Sigima coordinates — pre-existing and independent, reported in #69.Validation