Repository navigation
test(cloud-init): raise timeout for flaky cgroup verification test - #61
Open
defangdevs wants to merge 1 commit into
Open
defangdevs wants to merge 1 commit into
defangdevs wants to merge 1 commit into
Conversation
"rejects unsafe or unproven cgroup states" runs 13 cases that each spawn a real shell script via a temp dir, exceeding vitest's default 5000ms budget under CI load. It has timed out in CI on PRs #56, #59, and #60 (6-7s observed), unrelated to any of those PRs' own changes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/generate.test.ts > generateCloudInit > workload cgroup verification script > rejects unsafe or unproven cgroup statesruns 13 cases, each of which spawns a real shell script in a fresh temp dir viarunVerifyWorkloadCgroupScript.cloud-inittest has this pattern (one test, many real subprocess spawns), so this is scoped to just this test rather than the whole package'stestTimeout.Test plan
npx vitest run tests/generate.test.ts -t "rejects unsafe or unproven cgroup states"passes (1.08s locally)npx vitest runfor the wholecloud-initpackage passes (181/181)Agent Preflight (Required)
Classification
External References
N/A: no external API or third-party integration involved; this only adjusts a vitest per-test timeout value.
Codebase Impact Analysis
Single file touched:
packages/cloud-init/tests/generate.test.ts. Nosrc/code changed, no other package affected. Confirmed by running the fullcloud-inittest suite (181/181 passing) and the single targeted test before and after the change.Documentation & Specs
N/A: no behavior, interface, or public contract changed — only the timeout budget of one existing test.
Constitution & Risk Check
Reviewed for test-integrity risk: raising the timeout does not weaken any assertion in the test (same 13 cases, same expected exit codes/stderr substrings), it only gives the existing real-subprocess workload enough wall-clock time to finish under CI load. Confirmed the failure is pre-existing and repo-wide (observed identically on PRs #56, #59, #60) rather than introduced by this change.
🤖 Generated with Claude Code