Repository navigation
test(integration): skip crypto-* cases; the crypto API is intentionally disabled - #204
Merged
Merged
Conversation
…ly disabled The DSV crypto API (EaaS, /v1/crypto/*) is blocked on purpose: an API Gateway MOCK integration returns 403 on dev (2026-02-06/12) and in all four prod regions (2026-02-20), added after a security finding (Tom Dillenbeck; the feature had no customer usage). Every crypto-manual-* case therefore fails, which has kept the required dsv-cli.tests.integration check red on every PR since Feb 2026. Skip the 6 crypto-* cases (5 EaaS-Manual + key-delete in cleanup) with t.Skip and an explanation, so they report as SKIP rather than vanish; re-enabling is deleting the guard. No other case depends on them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
===========================================
+ Coverage 32.61% 47.47% +14.86%
===========================================
Files 80 87 +7
Lines 10855 11914 +1059
===========================================
+ Hits 3540 5656 +2116
+ Misses 7027 5981 -1046
+ Partials 288 277 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
typettitt
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required
dsv-cli.tests.integrationcheck has failed on every PR since Feb 2026 because of the crypto cases. That's why recent PRs (e.g. #203) needed admin bypass.Why
The DSV crypto API (EaaS,
/v1/crypto/*) is intentionally disabled server-side. An API Gateway MOCK integration returns 403 on/v1/crypto/{proxy+}on dev (2026-02-06/12) and in all four prod regions (2026-02-20). Tom Dillenbeck confirmed (2026-09-29) he added it after a security finding; the feature had no customer usage. Everycrypto-manual-*case gets a 403 from the edge and fails.Change
cicd-integration/integration_test.go: cases namedcrypto-*callt.Skip(...)with the reason, so they show as SKIP in the output instead of vanishing. That's the 6 cases: 5EaaS-Manual+crypto-manual-key-deletein cleanup. No other case depends on them. Re-enabling is deleting the guard.The CLI's
cryptocommands are unchanged; only the integration test stops expecting the server to answer.Companion change for the backend acceptance tests: api-bambe PR 228980 (ADO).
Testing
go vet ./cicd-integration/andgofmt: clean. The real verification is this PR'sdsv-cli.tests.integrationrun against the dev tenant: expect thecrypto-*subtests as SKIP and everything else as PASS.🤖 Generated with Claude Code
AB#767047