Skip to content

Fix swapped Linux artifact names and update flake inputs - #235

Merged
lucperkins merged 2 commits into
mainfrom
fix-linux-artifact-names
Nov 21, 2026
Merged

lucperkins merged 2 commits into
mainfrom
fix-linux-artifact-names

Conversation

@lucperkins

@lucperkins lucperkins commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

This PR does two things before we tag v0.1.28.

Fix swapped Linux artifact names

The build matrix uploads the aarch64-linux build as fh-X64-Linux and the x86_64-linux build as fh-ARM64-Linux.
The release workflows pass those names straight through, so releases ship each Linux binary under the other architecture's name.

This is already visible in v0.1.27, where the fh-X64-Linux release asset is an aarch64 executable:

$ file fh-X64-Linux
ELF 64-bit LSB pie executable, ARM aarch64, ... interpreter /nix/store/...-glibc-.../lib/ld-linux-aarch64.so.1

This PR swaps the two artifact names so that each matches its nix-system.

Update flake inputs

Runs nix flake update to refresh flake.lock.
This replaces #234.

Input From To
nixpkgs 0.1.1095516 (2026-10-17) 0.1.1124497 (2026-11-19)
fenix 0.1.2805 (2026-10-01) 0.1.2836 (2026-11-01)
fenix/rust-analyzer-src 03fcb77 (2026-09-27) 9e0d1ec (2026-10-30)

crane was already at its latest release, so it is unchanged.

Testing

  • Artifact names: the build workflow ran on the first commit of this PR, and file on the uploaded artifacts shows fh-ARM64-Linux is aarch64, fh-X64-Linux is x86-64, and fh-ARM64-macOS is arm64.
  • Flake inputs: in the updated dev shell on aarch64-darwin (rustc 1.99.1), cargo fmt --check, cargo clippy --all-targets --all-features -- -Dwarnings, cargo test --all-features (18 passed), and check-nix-fmt all pass.
    nix flake check was not run locally and is left to CI.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Linux build matrix now maps aarch64-linux to fh-ARM64-Linux and x86_64-linux to fh-X64-Linux.

Changes: Linux build artifacts

Layer / File(s) Summary
Match artifact names to architectures
.github/workflows/build.yml
The build matrix assigns fh-ARM64-Linux to aarch64-linux and fh-X64-Linux to x86_64-linux.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: grahamc

Merge Risk: Minimal · up to 426b2

Merge Risk: ⚪ Minimal · up to 426b2

This fixes the swapped Linux artifact names in the build workflow, so ARM64 and X64 binaries are labeled correctly. No concrete merge risk was found. The failing flake-check is caused by an outdated nixpkgs input and is separate from this change.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Inconclusive The title names the main change: the Linux artifact names in the build workflow were swapped and are now corrected to match their architectures. The title also mentions flake input updates, but the pr… Confirm whether the flake input update is part of this PR. If it is, add the flake change to the PR summary. If it is not, remove the flake clause from the title, for example: "Fix swapped Linux artifact names in build workflow".
Passed Passed checks: 3 passed

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names the main change: the Linux artifact names in the build workflow were swapped and are now corrected to match their architectures. The title also mentions flake input updates, but the provided summary only covers the build workflow change in .github/workflows/build.yml. That extra clause is not supported by the changeset evidence, so the title is only partially related.

Resolution

Confirm whether the flake input update is part of this PR. If it is, add the flake change to the PR summary. If it is not, remove the flake clause from the title, for example: "Fix swapped Linux artifact names in build workflow".

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 2df10101-b336-4aaa-a25a-ea8deb462537
Commits

Reviewing files that changed from the base of the PR and between 04ace30 and fc3b858.

Files selected for processing: 1

  • .github/workflows/build.yml

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@lucperkins lucperkins changed the title Fix swapped Linux artifact names in build workflow Fix swapped Linux artifact names and update flake inputs Nov 20, 2026
@lucperkins lucperkins mentioned this pull request Nov 20, 2026
@lucperkins
lucperkins merged commit 39da664 into main Nov 21, 2026
8 checks passed
@lucperkins
lucperkins deleted the fix-linux-artifact-names branch November 21, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants