Repository navigation
feat(core): expand console identification with multi-phase detection - #6
Merged
Merged
Conversation
Dev-Sams1012
force-pushed
the
feat/multi-phase-identification
branch
from
July 30, 2026 23:34
60c4206 to
3a81888
Compare
- Refactor `ConsoleIdentifier` to implement a 3-phase detection pipeline: container detectors, container resolvers, and binary detectors. - Add `IContainerDetector` and `IContainerResolver` interfaces for extension-based logic and ambiguity resolution. - Add `CueSheetResolver` to parse `.cue` sheets and dynamically locate target binary files. - Implement container detectors for Dreamcast formats (`DreamcastGdiDetector`, `DreamcastCdiDetector`). - Add binary detectors for PSP, PSP Homebrew (`PbpDetector`), Sega CD, and Saturn. - Update `Ps1Detector` and implement `Ps2Detector` to safely disambiguate discs using `SYSTEM.CNF` and `BOOT2` signatures. - Expand `Console` enum with `DreamcastModificado`, `PSP_PBP`, `Saturn`, and `SegaCD`. - Add `IdentificationEngineFactory` to encapsulate the instantiation and registration of all detectors and resolvers.
Dev-Sams1012
force-pushed
the
feat/multi-phase-identification
branch
from
July 30, 2026 23:35
3a81888 to
c81d3b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IdentificationEngineFactoryto bootstrap the multi-phase detection engineIContainerDetectorandIContainerResolverinterfacesCueSheetResolverto resolve .cue files to underlying binariesDreamcastGdiDetectorandDreamcastCdiDetectorfor container matchingPs1Detectorto accurately differentiate from Ps2 headers using BOOT2Consoleenum to include newly supported platformsConsoleIdentifierto support larger offsets