Skip to content

build: stop pulling setuptools into runtime dependencies#115

Open
federicobond wants to merge 1 commit into
DevCycleHQ:mainfrom
federicobond:remove-setuptools-runtime-dep
Open

build: stop pulling setuptools into runtime dependencies#115
federicobond wants to merge 1 commit into
DevCycleHQ:mainfrom
federicobond:remove-setuptools-runtime-dep

Conversation

@federicobond

@federicobond federicobond commented Jul 22, 2026

Copy link
Copy Markdown

setuptools was listed in requirements.txt and thus propagated to install_requires, forcing it as a runtime dependency for downstream installs even though it is never imported at runtime.

Remove it from requirements.txt and instead declare it as a build-time requirement only.

Copilot AI review requested due to automatic review settings July 22, 2026 18:33
@federicobond
federicobond requested a review from a team as a code owner July 22, 2026 18:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the package’s dependency metadata so that setuptools is no longer propagated as a runtime requirement to downstream consumers, while still ensuring it is available for build-time packaging.

Changes:

  • Removed setuptools from requirements.txt so it no longer ends up in install_requires.
  • Added a PEP 517 [build-system] section to pyproject.toml to declare setuptools as a build requirement.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
requirements.txt Removes setuptools from the dependency list that is used to populate runtime install_requires.
pyproject.toml Declares setuptools as the PEP 517 build backend requirement (but currently missing wheel).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
@federicobond

Copy link
Copy Markdown
Author

responses should also be dropped from runtime dependencies (it's already in requirements.test.txt)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants