build: stop pulling setuptools into runtime dependencies#115
Open
federicobond wants to merge 1 commit into
Open
build: stop pulling setuptools into runtime dependencies#115federicobond wants to merge 1 commit into
federicobond wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the package’s dependency metadata so that setuptools is no longer propagated as a runtime requirement to downstream consumers, while still ensuring it is available for build-time packaging.
Changes:
- Removed
setuptoolsfromrequirements.txtso it no longer ends up ininstall_requires. - Added a PEP 517
[build-system]section topyproject.tomlto declaresetuptoolsas a build requirement.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| requirements.txt | Removes setuptools from the dependency list that is used to populate runtime install_requires. |
| pyproject.toml | Declares setuptools as the PEP 517 build backend requirement (but currently missing wheel). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptoolswas listed inrequirements.txtand thus propagated toinstall_requires, forcing it as a runtime dependency for downstream installs even though it is never imported at runtime.Remove it from requirements.txt and instead declare it as a build-time requirement only.