chore(deps-dev): bump vitest from 4.1.11 to 5.0.0 - #195
Conversation
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 4.1.11 to 5.0.0. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.0/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-version: 5.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
5c8893b to
aeed94f
Compare
vitest 5 declares `node: ^22.12.0 || ^24.0.0 || >=26.0.0`. Every job here ran Node 20, so the two required checks that gate this PR — lint-typecheck-test-secrets and privacy-canary — were running vitest on a version it does not support. They passed, but by luck: npm treats `engines` as advisory (no `.npmrc`, so engine-strict is off), and this suite happens not to touch anything Node 22-only. The first 5.x patch that does would break main rather than a PR, and would read as an unrelated failure. `engines.node` stays `>=20`. vitest is a devDependency, so the floor for people who *install* Paragent is untouched; only the floor for people who *build* it moves. docs/DEVELOPMENT.md now says that outright, including the part worth knowing: nothing in CI exercises the product on Node 20 any more, so that promise now rests on `engines` alone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Review: not merged — the bump outruns the Node this repo builds onAll required checks are green, so this looks mergeable. It isn't, and the reason doesn't show up in the check list. The finding
Every CI job here runs Node 20:
So the required checks that gate this merge are running vitest 5 on a Node version vitest 5 does not support. CI is green by luck, not by support. What I verified
Why I did not just bump CI and mergeNode 20 is not an incidental pin. It is written into ADR-0001 ("TypeScript + Node 20+ + Playwright"),
Both point the same way — the dev toolchain and the published runtime floor are now different numbers — but which way you resolve it (bump CI to 22, or add a Node 20 job that runs the built product, or hold at vitest 4) is a call for you, not for a dependabot PR. AppliedI have pushed the minimal fix to this branch: CI and release workflows moved to Node 22, Left open for your call, since it is a real coverage regression: nothing now exercises the product on Node 20 while |
Bumps vitest from 4.1.11 to 5.0.0.
Release notes
Sourced from vitest's releases.
... (truncated)
Commits
f441c6fchore: release v5.0.0 (#11130)d46a747fix: treat test.describe as a suite during static collection (#11128)584cf30fix: add a warning if inline project has duplicate plugins due to unexpected ...f08ce4bfix: apply queued mocks from doMock() in queue order (fixes #10706) (#11127)897f51fchore: release v5.0.0-rc.4 (#11107)1339b06chore(deps): update all non-major dependencies (#11104)51e9494feat!: parse files statically in vitest list by default (#11088)2122ffdfix: propagate --maxWorkers to projects (#11102)dc10f5ffix(browser): report the action error when a task times out (#11101)d4fe198feat: promote clearCache out of experimental (#11086)