Skip to content

Avoid spurious warnings for multiple definitions of (story release $) #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dstelzer merged 1 commit into from
Nov 2, 2026
Merged

Avoid spurious warnings for multiple definitions of (story release $) #372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/backend.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,18 @@ void suggest_new_ifid(int level) {
}
}

static int multiple_definitions_outside_library(struct program *prg, struct predicate *pred) {
// Duplicates some of the logic of decode_metadata_str in frontend.c - TODO consolidate
int i, nfound=0, nlib=0;
for(i = 0; i < pred->nclause; i++) {
nfound++;
if(FILENUMPART(pred->clauses[i]->line) == prg->lib_file) { // This one was in a library file
nlib ++;
}
}
return nfound - nlib > 1;
}

void usage(char *prgname) {
fprintf(stderr, "Dialog compiler " VERSION ".\n");
fprintf(stderr, "Original compiler copyright 2018-2021 Linus Akesson.\n");
Expand Down Expand Up @@ -342,7 +354,7 @@ int main(int argc, char **argv) {
exit(1);
}
prg->meta_release = pred->clauses[0]->params[0]->value;
if(pred->nclause > 1) {
if(multiple_definitions_outside_library(prg, pred)) {
report(LVL_WARN, pred->clauses[0]->line, "%d separate definitions found for (story release $). Only the first (at this line) will be used.", pred->nclause);
}
} else {
Expand Down
Loading