Skip to content

ENG-519 Make human-readable labels for node ids - #1271

Open
maparent wants to merge 3 commits into
mainfrom
eng-519-make-human-readable-labels-for-node-ids
Open

ENG-519 Make human-readable labels for node ids#1271
maparent wants to merge 3 commits into
mainfrom
eng-519-make-human-readable-labels-for-node-ids

Conversation

@maparent

@maparent maparent commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

https://linear.app/discourse-graphs/issue/ENG-519/make-human-readable-labels-for-node-ids

https://www.loom.com/share/e8b03f27c6a947fbaea0ebf416a0981b

This is essentially the Claude code, unmodified. (I added a try-catch as recommended by Devin.)

check-types started failing as a strange side-effect, but it was easy to fix and the fixes also make sense.


Open in Devin Review

@linear-code

linear-code Bot commented Jul 30, 2026

Copy link
Copy Markdown

ENG-519

@supabase

supabase Bot commented Jul 30, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
discourse-graph Skipped Skipped Aug 4, 2026 3:13am

Request Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread apps/obsidian/src/utils/nodeTypeIdPropertyWidget.ts
Comment thread apps/obsidian/src/utils/nodeTypeIdPropertyWidget.ts Outdated
Comment thread apps/obsidian/src/utils/nodeTypeIdPropertyWidget.ts
@maparent
maparent marked this pull request as draft July 30, 2026 21:02
@maparent
maparent force-pushed the eng-519-make-human-readable-labels-for-node-ids branch from b761a64 to 4956cbc Compare July 30, 2026 22:17
@maparent
maparent force-pushed the eng-519-make-human-readable-labels-for-node-ids branch from 4956cbc to 974bfa0 Compare August 1, 2026 16:36
@maparent
maparent force-pushed the eng-519-make-human-readable-labels-for-node-ids branch from 974bfa0 to 24a2c92 Compare August 3, 2026 20:53
@maparent
maparent force-pushed the eng-519-make-human-readable-labels-for-node-ids branch from 24a2c92 to bb47db8 Compare August 3, 2026 20:59
@maparent
maparent force-pushed the eng-519-make-human-readable-labels-for-node-ids branch from 1e10a90 to 422ca86 Compare August 4, 2026 03:11
@maparent
maparent force-pushed the eng-519-make-human-readable-labels-for-node-ids branch from 422ca86 to e599ea4 Compare August 4, 2026 03:13
@maparent
maparent requested a review from mdroidian August 4, 2026 03:15
@maparent
maparent marked this pull request as ready for review August 4, 2026 10:49
@graphite-app

graphite-app Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

"esbuild": "0.17.3",
"eslint": "catalog:",
"obsidian": "^1.7.2",
"obsidian-typings": "^6.29.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This package is not affiliated with, or endorsed by, the Obsidian team.

@maparent I'm uncomfortable adding unofficial typings to our package.json

I'd rather have a separate unofficial-types.ts (or similar) that we maintain, that only includes the unofficial types that we added, and that we specifically need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants