ENG-519 Make human-readable labels for node ids - #1271
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
b761a64 to
4956cbc
Compare
4956cbc to
974bfa0
Compare
974bfa0 to
24a2c92
Compare
24a2c92 to
bb47db8
Compare
1e10a90 to
422ca86
Compare
422ca86 to
e599ea4
Compare
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
| "esbuild": "0.17.3", | ||
| "eslint": "catalog:", | ||
| "obsidian": "^1.7.2", | ||
| "obsidian-typings": "^6.29.0", |
There was a problem hiding this comment.
- This package is not affiliated with, or endorsed by, the Obsidian team.
@maparent I'm uncomfortable adding unofficial typings to our package.json
I'd rather have a separate unofficial-types.ts (or similar) that we maintain, that only includes the unofficial types that we added, and that we specifically need.
https://linear.app/discourse-graphs/issue/ENG-519/make-human-readable-labels-for-node-ids
https://www.loom.com/share/e8b03f27c6a947fbaea0ebf416a0981b
This is essentially the Claude code, unmodified. (I added a try-catch as recommended by Devin.)
check-types started failing as a strange side-effect, but it was easy to fix and the fixes also make sense.