[ENG-2098] Materialize Roam-origin markdown into Roam - #1275
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
98a538f to
b4c4201
Compare
b4c4201 to
090f66c
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Accepts Roam-origin shared nodes in the Roam materializer: the expected full content type is now derived from the node's platform (
text/roam+markdownfor Roam,text/obsidian+markdownfor Obsidian), and Roam-origin full content gets its leading# titleheading stripped on import when the first line matches the shared title exactly — otherwise the text is left untouched. The producer format stays unchanged; strip-on-import keeps the validated Roam→Obsidian path as is.The platform gate in
validateSharedNodeandisImportableSharedNodein the discovery dialog are removed rather than extended: with bothPlatformenum values (Roam,Obsidian) now supported, both checks would be dead code by type.Stacked on #1269 (ENG-1859).
Scope check
$scope-checkagainst ENG-2098 and the final diff.Done When: None.