Skip to content

Admin pages have almost no tests (only integrity and RequireAdmin are covered) #1989

Closed

Description

@yusuftomilola

Problem

Under frontend/app/admin only integrity has a test. accounts, charge, credits, payments, refund, settlements, splits (and their [id] pages), which move money, have none. The charge and refund forms in particular have validation and confirmation logic that regressions can break unnoticed.

Proposed change

Add Vitest + Testing Library tests with mocked API modules for: charge (validation, confirm step, success and error), refund (amount bounds, reason required), accounts (list, create, freeze), splits (edit totals must equal 10000 basis points) and settlements (run, retry, abandon).

Acceptance criteria

  • Each listed page has tests for success and failure paths; coverage for app/admin exceeds 60%.

Activity

  1. LayanGift commented on Oct 17, 2026

    @LayanGift

    @LayanGift has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    i can assure you a grate work done solving this issue following the key prompts needed to be fix i can deliver a great code that will significantly impact you work given the chance to work on your project

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @LayanGift to this issue.

  2. abiolatousin-design commented on Oct 17, 2026

    @abiolatousin-design

    @abiolatousin-design has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I’d love to take this issue on and turn it into a solid contribution to the project. I’m ready to get started and work toward a clean, reliable solution.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @abiolatousin-design to this issue.

  3. Ahmedxnn commented on Oct 17, 2026

    @Ahmedxnn

    @Ahmedxnn has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello Maintainer, I’m a well experienced software engineer. I’d love to work on this issue.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ahmedxnn to this issue.

  4. ObedChibunna commented on Oct 17, 2026

    @ObedChibunna
    Contributor

    @ObedChibunna has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I will love to handle this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @ObedChibunna to this issue.

  5. drips-wave commented on Oct 18, 2026

    @drips-wave

    Congratulations, @ObedChibunna! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @ObedChibunna: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  6. added a commit that references this issue on Oct 20, 2026
  7. grantfox-oss commented on Oct 20, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @ObedChibunna's PR #2063 was approved and merged by @yusuftomilola.

    🏆 @ObedChibunna: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (567 total points). Track your full progress on GrantFox.

    👏 Great work, @ObedChibunna! Keep contributing to DistinctCodes.

  8. drips-wave commented on Oct 20, 2026

    @drips-wave

    This issue has been completed by @ObedChibunna as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @ObedChibunna: You earned 150 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions