Skip to content

mdetail.php: Catch exception for invalid uid, add smoke test - #1635

Closed
bpfoley wants to merge 1 commit into
DistributedProofreaders:masterfrom
bpfoley:mdetail-no-such-user
Closed

mdetail.php: Catch exception for invalid uid, add smoke test#1635
bpfoley wants to merge 1 commit into
DistributedProofreaders:masterfrom
bpfoley:mdetail-no-such-user

Conversation

@bpfoley

@bpfoley bpfoley commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@cpeel cpeel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want this. This is a user doing something sneaky and we'd rather raise the exception and let the exception handler have it -- the production exception handler is "nicer" about this than the one on test which outputs the entire stacktrace.

@srjfoo

srjfoo commented Sep 7, 2026

Copy link
Copy Markdown
Member

I don't think we want this. This is a user doing something sneaky and we'd rather raise the exception and let the exception handler have it -- the production exception handler is "nicer" about this than the one on test which outputs the entire stacktrace.

And I frequently do sneaky things during testing. I did mostly mention it just in case it was worth fixing.

But I do frequently change org to net and vice versa (with no intention of being sneaky) for the common pages when I realize I'm on one server when I wanted the other (like for the AH or one of the round pages), so, in this case, it wasn't that it was with the intention of being sneaky that I did it; I just didn't consider that the ID number was so far ahead of what was likely to be on TEST that it would obviously fail before I did it.

@cpeel

cpeel commented Sep 7, 2026

Copy link
Copy Markdown
Member

But I do frequently change org to net and vice versa (with no intention of being sneaky) for the common pages when I realize I'm on one server when I wanted the other (like for the AH or one of the round pages), so, in this case, it wasn't that it was with the intention of being sneaky that I did it; I just didn't consider that the ID number was so far ahead of what was likely to be on TEST that it would obviously fail before I did it.

Yup, and that's all valid -- but our position in the past has been "users who do 'sneaky' things get exceptions" which the exception handler on PROD makes into something a little more human readable.

@bpfoley bpfoley closed this Sep 8, 2026
@bpfoley
bpfoley deleted the mdetail-no-such-user branch September 8, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants