Repository navigation
fix(ci): run the backup restore drill on Postgres 18 - #266
Merged
Merged
Conversation
The runner's newer pg_dump wrote a setting the drill's Postgres 16 server rejected on restore. Match the Render database's version, use the declared client version, and fail clearly if they differ. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Malware scan: passed, with notes for the reviewerNothing malicious was detected in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backup restore drill has failed since Nov 2 with:
GitHub moved
ubuntu-latestto an image whosepostgresql-clientis version 18, while the drill's server was Postgres 16. A newerpg_dumpwritesSET transaction_timeout, which that server doesn't recognise.PGCLIENT_VERSION: '16'was set but never used.Changes
postgresql-client-${PGCLIENT_VERSION}and puts that version first onPATH.PGCLIENT_VERSION.Not covered: this drill backs up a small seeded test database, so it proves the scripts work. It doesn't back up real data.
The drill is running on this branch to check the fix before merge.
🤖 Generated with Claude Code