fix: allow hidden collaborator emails#250
Merged
Merged
Conversation
goncalossilva
approved these changes
Jun 3, 2026
goncalossilva
left a comment
goncalossilva
left a comment
Member
There was a problem hiding this comment.
Change looks good! Instead of a new test, we could add/tweak a fixture?
Per review, the nullable-email case lives in the default collaborator fixtures instead of a standalone test, so the existing pagination test exercises it on both sync and async paths. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The backend currently sends the hidden@todoist.com placeholder for hidden collaborator emails; null is a possible future contract (Doist/Issues#20418), not today's behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
doistbot
reviewed
Jul 2, 2026
doistbot
left a comment
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR updates fix: allow hidden collaborator emails. No issues were flagged in the reviewed diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References https://github.com/Doist/Issues/issues/20418.