Skip to content

test: add unit tests for WebDriver.orientation - #33

Closed
Dor-bl wants to merge 4 commits into
masterfrom
test-webdriver-orientation-9270917889273079202
Closed

Dor-bl wants to merge 4 commits into
masterfrom
test-webdriver-orientation-9270917889273079202

Conversation

@Dor-bl

@Dor-bl Dor-bl commented Oct 19, 2026

Copy link
Copy Markdown
Owner

PR Title: test: add unit tests for WebDriver.orientation

🎯 What

Adds missing unit tests for WebDriver.orientation getter and setter property in appium/webdriver/webdriver.py.

📊 Coverage

  • Getting orientation returns expected orientation value (GET /session/$sessionId/orientation).
  • Setting orientation sends expected orientation payload (POST /session/$sessionId/orientation).
  • Setting invalid orientation value raises WebDriverException.

✨ Result

Improves test coverage and reliability for WebDriver.orientation in test/unit/webdriver/webdriver_test.py.


PR created automatically by Jules for task 9270917889273079202 started by @Dor-bl

claude and others added 2 commits September 12, 2026 22:34
The Release workflow triggers on every push to master. On a fork that means
semantic-release rewrites the version in pyproject.toml, commits the change to
the default branch, tags it and then tries to publish the result to PyPI under
the upstream package name.

Gate the job on the repository name so forks keep a clean master.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PjZRpyoEfSCLjTx5ctzQmJ
Add unit tests for getter, setter, and invalid value handling of
the WebDriver.orientation property in test/unit/webdriver/webdriver_test.py.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Add unit tests for getter, setter, and invalid value handling of
the WebDriver.orientation property in test/unit/webdriver/webdriver_test.py.
Add unit tests for getter, setter, and invalid value handling of
the WebDriver.orientation property in test/unit/webdriver/webdriver_test.py.
@Dor-bl
Dor-bl force-pushed the master branch 2 times, most recently from df25536 to ce054d4 Compare October 26, 2026 18:03

Dor-bl commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

Closing: master already covers orientation in webdriver_test.py (getter, setter, case normalization, invalid value), added upstream with appium#1308. Against current master, test_set_orientation also fails, because the setter now uppercases 'portrait' before sending it.


Generated by Claude Code

@Dor-bl Dor-bl closed this Nov 7, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing: master already covers orientation in webdriver_test.py (getter, setter, case normalization, invalid value), added upstream with appium#1308. Against current master, test_set_orientation also fails, because the setter now uppercases 'portrait' before sending it.


Generated by Claude Code

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants