Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ permissions:

jobs:
release:
# Releases are cut from the upstream repository only. Without this guard the
# workflow also runs on forks, where semantic-release rewrites the version in
# pyproject.toml, commits to the default branch and attempts a PyPI upload.
if: github.repository == 'appium/python-client'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
Expand Down
3 changes: 2 additions & 1 deletion appium/webdriver/appium_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,8 @@ def is_listening(self) -> bool:
if not self.is_running:
return False

assert self._cmd
if not self._cmd:
raise AppiumServiceError('Appium service command has not been initialized')
try:
return is_service_listening(
_make_server_url(self._cmd),
Expand Down
14 changes: 14 additions & 0 deletions test/unit/webdriver/appium_service_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,17 @@ def advance_time(seconds):
assert service.is_listening is expected_result
assert clock.perf_counter.return_value == expected_elapsed
assert connection.request.call_args_list == [call('HEAD', 'http://127.0.0.1:4723/status')] * expected_requests

def test_is_listening_raises_error_when_cmd_is_empty(self):
service = AppiumService()
process = Mock()
process.poll.return_value = None
service._process = process
service._cmd = []

with pytest.raises(appium_service.AppiumServiceError, match='Appium service command has not been initialized'):
_ = service.is_listening

def test_is_listening_returns_false_when_not_running(self):
service = AppiumService()
assert service.is_listening is False
Loading