Repository navigation
Conversation
The Release workflow triggers on every push to master. On a fork that means semantic-release rewrites the version in pyproject.toml, commits the change to the default branch, tags it and then tries to publish the result to PyPI under the upstream package name. Gate the job on the repository name so forks keep a clean master. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PjZRpyoEfSCLjTx5ctzQmJ
Support both tuple coordinate pairs and individual coordinate arguments in `ActionHelpers.swipe`. Extracted point extraction logic into helper methods `_extract_start_point` and `_extract_end_point_and_duration` to reduce function complexity and parameter count. Added `@overload` type hints and unit tests.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing: superseded by upstream's own direction for this method. Generated by Claude Code |
Understood. Acknowledging that this work is now obsolete given upstream deprecation of ActionHelpers shortcuts in favor of W3C actions and mobile gesture extensions, and stopping work on this task. |
🎯 What
Refactored
swipeinappium/webdriver/extensions/action_helpers.pyto allow passing start and end points as tuples/lists as well as positional/keyword coordinate arguments. Extracted coordinate processing into dedicated helper methods_extract_start_pointand_extract_end_point_and_duration.💡 Why
The
swipemethod previously required 5 separate arguments (start_x,start_y,end_x,end_y,duration). Accepting coordinate tuples and using internal helper methods improves code maintainability and readability while preserving full backward compatibility.✅ Verification
test/unit/webdriver/action_helpers_test.pypass (207 passed).make check(ruff,mypy).✨ Result
Cleaner, more versatile
swipemethod API and improved maintainability ofActionHelpers.PR created automatically by Jules for task 11046140107786784364 started by @Dor-bl