Skip to content

bonsai-link skips a PR with no Bonsai mention instead of failing it - #68

Merged
mcarter-astronautdev merged 1 commit into
mainfrom
bonsai-link-skips
Oct 1, 2026
Merged

mcarter-astronautdev merged 1 commit into
mainfrom
bonsai-link-skips

Conversation

@mcarter-astronautdev

Copy link
Copy Markdown
Member

Most human PRs have no ticket, and the red X read as a failing build (Maria, 2026-10-01).

  • Kit: pr-bonsai-link.yml runs only when the PR body mentions hellobonsai.com; no mention is skipped (grey), a mention that is not a task URL stays red.
  • Docs: kit README row; the handoff and wave plan drop the plan to make it a required check.

Most human PRs have no ticket, and a red X read as a failing build. The job now runs only when
the body mentions hellobonsai.com, so no link is grey and a bad link is still red. The plan to
make it a required check is dropped: a check that passes when skipped would enforce nothing.
@macroscopeapp

macroscopeapp Bot commented Oct 1, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved at c217590

Macroscope's review found this PR approvable — This PR makes a narrow, well-documented CI policy adjustment: PRs without a Bonsai mention are neutral, while PRs containing a Bonsai reference continue to be validated. The remaining edits are documentation-only, with no production, schema, security, or deployment impact.

You can add or adjust custom eligibility rules. Learn more.

@mcarter-astronautdev
mcarter-astronautdev merged commit e28bd11 into main Oct 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant