Code cleanup/format/organize

[vanowm]

The code doesn't seem like use any lint formatting, even though the package has eslint installed. Code format consistency could help with better understanding how it works and just simply less stress on eyes.
Also, for easier maintenance and better linting all different languages should be separated into separate files, such as HTML, JavaScript and CSS should be separated.

So, if I may propose to include eslint.config.js config file into the repository, so contributors can follow the same rules.

[vanowm]

I'd like to help cleaning up the code, but with the rate @softwarecrash pushes updates it might create issues ;)

[dmorris68]

My biggest beef with the majority of the code is contained in header files. I'm an old school C programmer from the 80's and that was always a huge no-no from a best practices standpoint. Right up there with not using goto. Just because you CAN doesn't mean you SHOULD. I was trained that header files should contain declarations, not definitions that allocate memory or code. So every time I look at the BLLED code, I die a little inside LOL.

[softwarecrash]

I'd like to help cleaning up the code, but with the rate @softwarecrash pushes updates it might create issues ;)

Im Most done, only bugfixing now.
So yes the Code need a whole refactoring in the mqtt and Led section.
So i will Split it Up into classes and a bunch of States, but thats Not done in one week.

[softwarecrash]

My biggest beef with the majority of the code is contained in header files. I'm an old school C programmer from the 80's and that was always a huge no-no from a best practices standpoint. Right up there with not using goto. Just because you CAN doesn't mean you SHOULD. I was trained that header files should contain declarations, not definitions that allocate memory or code. So every time I look at the BLLED code, I die a little inside LOL.

your are right, but in the modern arduino style envroiment its legit to do this with header files. so for every class or function two files endet up in a mass of files, so for simple things its okay to use a header only file

but GOTO is funny :( and no good programmer like to see it :D

[dmorris68]

your are right, but in the modern arduino style envroiment its legit to do this with header files. so for every class or function two files endet up in a mass of files, so for simple things its okay to use a header only file

I'm not sure about that. While I admit I have not poured through every internal Arduino library and other public projects, I've done quite a lot of Arduino programming myself as well as other IoT and embedded systems programming. I've never put code in headers and don't see how Arduino makes that necessary or common. All of my Arduino projects look like pretty much every other C/C++ project I've written, that is to say separated between source and header files.

I could live with it, and have considered contributing to this project regardless. It just makes me cringe. :)