Repository navigation
Fix empirical E-value audit status for configurable ceilings - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fitting with
--audit-ceiling 400previously wrotevalidation_status: audited-e0-le-100, and both empirical parameter loaders only accepted that fixed label. The fitter now records the actual ceiling, and experimental/predicted loaders share validation of the audit metadata and fitted range.Existing fixed-100 labels remain compatible with an explicitly recorded larger audit ceiling, so previously fitted NuFold parameters do not need refitting for this metadata fix. Other label/ceiling mismatches, non-finite ceilings, and fitted ranges beyond the audited range are rejected. Scoring, Gumbel fitting, empirical mapping, and extrapolation are unchanged; no database-specific parameters are added.
Validation:
git diff --checkpassed.This PR fixes the metadata issue only; it does not implement same-cluster audit prefetch or change audit convergence limits.