Repository navigation
[DevOps]: Schedule diagnostics linking on Chrysalis and Spin - #367
Merged
tomvothecoder merged 2 commits intoOct 6, 2026
Merged
Conversation
tomvothecoder
marked this pull request as ready for review
October 6, 2026 17:10
tomvothecoder
force-pushed
the
devops/303-ingestion-script
branch
from
October 6, 2026 17:15
6e9da19 to
719aec7
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved scanner error-handling and whitespace-validation issues remain, along with a launcher lock regression-test gap.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds scheduled diagnostics linking for Chrysalis and NERSC Spin using the shared launcher, scanner, separate logs/locks, and operational documentation.
Changes:
- Adds diagnostics scheduling and launcher support.
- Improves scanner configuration and failure reporting.
- Adds regression tests and deployment runbooks.
| File | Summary |
|---|---|
docs/operations/test-ingestion-operations.md |
Documents diagnostics validation steps. |
docs/operations/setup-ingestion-operations.md |
Documents scheduled diagnostics operations. |
docs/operations/nersc-spin-runbook.md |
Adds the Spin diagnostics CronJob runbook. |
backend/tests/features/ingestion/test_site_collection_launcher.py |
Tests launcher behavior, locking, and scheduling; lock-invocation coverage needs strengthening. |
backend/tests/features/ingestion/test_diagnostics_link_scanner.py |
Covers scanner configuration and failure handling. |
backend/app/scripts/ingestion/sites/templates/crontab.example |
Adds development and production diagnostics schedules. |
backend/app/scripts/ingestion/sites/site_ingestion_launcher.sh |
Adds diagnostics routing, logging, and locking. |
backend/app/scripts/ingestion/diagnostics_link_scanner.py |
Adds scanner configuration and reporting; handled failures and whitespace validation require changes. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Closes #303.
Checklist
Validation
uv run --project backend pytest backend/tests/features/ingestion/test_site_collection_launcher.py backend/tests/features/ingestion/test_diagnostics_link_scanner.py --noconftest --no-cov --capture=sys -q.bash -n backend/app/scripts/ingestion/sites/site_ingestion_launcher.sh.make pre-commit-run(including Ruff and type checking) andgit diff --checkagainst main.make backend-testpreviously failed during setup because.envs/local/backend.envis absent. Per user instruction, full backend validation is deferred to CI/CD; no full-suite pass is claimed.Deployment Notes (if any)
DRY_RUN=false; valid protected dev/prod API credentials are required.Forbidconcurrency and a job backoff limit of zero.