Repository navigation
Fix local setup on macOS: stale seed path and bash 3.2 incompatibility - #372
Merged
Merged
Conversation
The seed script moved from app/scripts/seed.py to app/scripts/db/seed.py in E3SM-Project#105, but setup-local still invoked the old path. The trailing `|| true` hid the resulting "No such file" error, so setup-local reported success while leaving the database empty. Reuse the existing backend-seed target, which already has the correct module path, and let a seeding failure fail the setup.
The ${VAR,,} expansion requires bash 4.0+. macOS ships bash 3.2, where
it raises "bad substitution" and fails backend-test for any contributor
on that platform. Deployment targets and CI run Linux, so only local
development was affected.
Replace it with tr, which behaves identically on both versions.
Collaborator
|
Looks good to me, thanks. You can merge if it is ready. |
tomvothecoder
approved these changes
Oct 7, 2026
Collaborator
|
This actually fixes backend tests for other PRs too. I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
setup-localinvokedapp/scripts/seed.py, which moved toapp/scripts/db/seed.pyin#105;
|| truehid the error so setup reported success with an empty database. Separately,${DRY_RUN,,}needs bash 4+ and failsmake backend-teston macOS (bash 3.2). One-line fixeach, separate commits.
Checklist
Deployment Notes (if any)
None. Chrysalis and CI run bash 4+, where behavior is unchanged.