ci: install Rust with rustup instead of dtolnay/rust-toolchain - #746
Merged
Merged
Conversation
Every job that needs Rust ran two steps: a bash one-liner pulling the
channel out of rust-toolchain.toml, then dtolnay/rust-toolchain to
install it. rustup ships on every GitHub-hosted runner and reads
rust-toolchain.toml itself, so one step does both:
rustup toolchain install --profile minimal --no-self-update
installs the pinned channel plus the file's components (rustfmt,
clippy), and every later cargo call in the checkout, src-tauri/
included, resolves to it. The release build adds
`rustup target add "$RUST_TARGET"` for its matrix target.
This drops a third-party action from the build path, which is also
what was turning Lint (workflows) red: upstream moved its v1 tag, so
the pin's version comment stopped matching (#741). With no pin there is
nothing to drift or to re-review on each upstream push. Quantco/pixi-pack
made the same change (Quantco/pixi-pack#340).
Given up: the action's new retry on release-server checksum failures.
That only bites while a Rust release is mid-publish.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SCNjpC4VgppHSFs7P6rkZg
This was referenced Oct 5, 2026
Merged
EVWorth
added a commit
that referenced
this pull request
Oct 5, 2026
Version bump across the three manifests and the two lockfile entries that record the app's own version. What 1.2.0 contains since 1.1.0: - Each editor tab runs on its own server session, so SET @var, temporary tables and multi-run transactions carry across runs (#734) - Separate connection lanes for the agent and for backups/restores, so neither can starve the editor; the pool-exhausted message says what is holding the pool (#732, #727) - Copy button beside Expand for long cell values, such as SHOW CREATE TABLE (#748) - Linux/Wayland: WebKitGTK's DMABUF renderer is turned off, for the black area left after resizing the window (#742) - Tauri 2.12 on both the npm and Rust sides (#749), and the dependency roll-up in #740 - rustls TLS 1.3 advisory RUSTSEC-2026-0285 patched (#728) Also the first release built with rustup in place of dtolnay/rust-toolchain (#746), so the release jobs' toolchain step runs on Windows and macOS for the first time. Claude-Session: https://claude.ai/code/session_01SCNjpC4VgppHSFs7P6rkZg Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
dtolnay/rust-toolchainaction from CI and release. Once it merges, #741's red Lint (workflows) check clears.Why
rustupcomes preinstalled on every GitHub-hosted runner and readsrust-toolchain.tomlitself, so the action was a third-party step doing what the runner already can. Quantco/pixi-pack made the same change in ci: Replace dtolnay/rust-toolchain by simple rustup command Quantco/pixi-pack#340.v1tag, so our pin's# v1note stopped matching andcheck-action-pins.shfailed every PR that touchesscripts/or the workflows. With no pin, there's nothing to fall out of date or re-review each time upstream pushes.Change
Each Rust job used to run two steps: a
sedone-liner that pulled the channel out ofrust-toolchain.toml, then the action. Now it's one step:cargocall in the checkout uses it, including insrc-tauri/.rustup target add "$RUST_TARGET". The target is passed throughenvrather than written straight into the shell line.shell: bashis kept because the Windows release runner defaults to PowerShell.ci.yml(cargo Audit, Lint (Rust), Test Rust) andrelease.yml(integration DB, build matrix).mise.tomlandrust-toolchain.tomlthat named the action now say rustup.Given up: the action's checksum-failure retry, added this week in dtolnay/rust-toolchain#186. It only matters while a Rust release is being published.
Verification
rustup target addadded to the same toolchain.actionlint(the version pinned inmise.toml, checksum-verified, with shellcheck at--severity=infoas in CI): clean.check-action-pins.sh --offline,test-check-action-pins.sh(12/12),check-documented-commands.shanddprint check: clean.release.ymlonly runs on a release, so the Windows and macOS build steps are first tested on the next release.🤖 Generated with Claude Code
https://claude.ai/code/session_01SCNjpC4VgppHSFs7P6rkZg
Generated by Claude Code