Linter fixes#1569
Conversation
git-subtree-dir: src/secp256k1 git-subtree-split: 95b983597af0e5762a1266ede302806883045d22
delta1
left a comment
delta1
left a comment
There was a problem hiding this comment.
It's difficult to review this without the linter job in CI. Is there an example run somewhere?
| if [ -n "$NO_DEPENDS" ]; then | ||
| echo "Building with CMake (NO_DEPENDS=1)..." | ||
| cmake -B build -S . ${CMAKE_GENERATOR:+-G "$CMAKE_GENERATOR"} $BITCOIN_CONFIG_ALL | ||
| cmake -B build -S . ${CMAKE_GENERATOR:+-G "$CMAKE_GENERATOR"} "$BITCOIN_CONFIG_ALL" |
There was a problem hiding this comment.
No. Better to disable the shellcheck warning for this.
| @@ -161,7 +161,7 @@ def script_BIP34_coinbase_height(height): | |||
| return CScript([CScriptNum(height)]) | |||
|
|
|||
|
|
|||
| def create_coinbase(height, pubkey=None, *, script_pubkey=None, extra_output_script=None, fees=0, nValue=50, retarget_period=REGTEST_RETARGET_PERIOD): | |||
| def create_coinbase(height, pubkey=None, *, script_pubkey=None, extra_output_script=None, fees=0, nValue=50): | |||
There was a problem hiding this comment.
just noting that this breaks mining_mainnet.py but we have that commented out in CI
There was a problem hiding this comment.
lint-python-dead-code.py flagged it was unused (because mining_mainnet.py was disabled)
I'll put it back and add and exception to dead code ignore list.
|
ACK bd2dbdc; tested locally linter is |
It's added to GHA later on in the 29.x branch upstream: bitcoin/bitcoin#33403 |
2 participants
Fixes for the v29 branch point linter checks.
tests/bitcoin_functionalobsolete tests removed.