Skip to content

feat: CDM: Glow when Visible, Glow When Usable and per-ability Bar Glows - #2615

Merged
EllesmereGaming merged 8 commits into
EllesmereGaming:mainfrom
PersonalEricOrg:feat/cdm-glow-when-visible
Oct 13, 2026
Merged

EllesmereGaming merged 8 commits into
EllesmereGaming:mainfrom
PersonalEricOrg:feat/cdm-glow-when-visible

Conversation

@ericellb

@ericellb ericellb commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Glow when Visible - For buffs that generally are only shown when missing this allows you to have them glow. Useful to notify when missing important buffs like Battle Shout that need refreshing.
  • Bar Glows: Glow When Usable: New feature part of bar Glows that will glow the ability on your action bar when usaable. Useful to notify when you can use Revenge, Overpower, Execute, Victory Rush etc...
  • Bar Glows are now saved per ability instead of per button, so stance and form swaps no longer move a glow onto a different ability than the one you set it up on.
  • All new options are off by default. Events and frames only exist while one of these glows is in use. Rebinding reuses the existing CDM event handler

How was it tested?

  • Tested in game: Show when missing & Glow on Shield Block, will glow the ability when its not active and usable
  • Tested in game: Glow action bar on Revenge, Overpower, Execute will glow when the ability can be used

Screenshots

Buff Glow when Missing (Used Shield Block since BS is broken on Blizz CDM now)
image

Glow Action bar Config
glow-action-bar-usable

Glowing Revenge + Execute when usable on Bars
glow-rev-ex

Checklist

  • New settings default OFF (no behavior change without opt-in)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added

…ability Bar Glows

- Glow when Visible: per-icon toggle that glows a buff or cooldown icon while it is shown (Show When Missing, Hidden Until Usable)
- Bar Glows: new Glow When Usable entry that follows Hidden Until Usable (off cooldown and usable)
- Bar Glows: action bar glows are saved per ability so stance and form swaps no longer move a glow onto another ability

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ericellb ericellb changed the title feat: Glow when Visible, Glow When Usable and per-ability Bar Glows feat: CDM: Glow when Visible, Glow When Usable and per-ability Bar Glows Oct 10, 2026
if ns.QueueReanchor then ns.QueueReanchor() end
end

-- Events that can move an ability to another action button (Bar Glows keyed per ability).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used to handle stance / form swapping. So the glow you setup is on a per ability basis instead of a per action bar button number basis

do
local pool = {}
local n = 36
local n = 39

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was already 34 exisitng TakeShell call sites, raised this just to ensure it doesnt break

ericellb and others added 7 commits October 10, 2026 18:53
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Restore main's Pixels border frame levels in EUI_CDM_Icons.lua
- Migrate only entries that saved an actionSpellID to ability keys
- Reuse scan tables and skip unrelated ACTIONBAR_SLOT_CHANGED rebinds
- Decide Glow When Usable cooldown state inside the cooldown event
- Drop the Cooldown State half of Glow When Visible (buff icons only)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@EllesmereGaming
EllesmereGaming merged commit 1bf5ba9 into EllesmereGaming:main Oct 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants