Repository navigation
feat: CDM: Glow when Visible, Glow When Usable and per-ability Bar Glows - #2615
Merged
EllesmereGaming merged 8 commits intoOct 13, 2026
Merged
EllesmereGaming merged 8 commits into
EllesmereGaming merged 8 commits into
Conversation
…ability Bar Glows - Glow when Visible: per-icon toggle that glows a buff or cooldown icon while it is shown (Show When Missing, Hidden Until Usable) - Bar Glows: new Glow When Usable entry that follows Hidden Until Usable (off cooldown and usable) - Bar Glows: action bar glows are saved per ability so stance and form swaps no longer move a glow onto another ability Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ericellb
commented
Oct 10, 2026
| if ns.QueueReanchor then ns.QueueReanchor() end | ||
| end | ||
|
|
||
| -- Events that can move an ability to another action button (Bar Glows keyed per ability). |
Contributor
Author
There was a problem hiding this comment.
This is used to handle stance / form swapping. So the glow you setup is on a per ability basis instead of a per action bar button number basis
| do | ||
| local pool = {} | ||
| local n = 36 | ||
| local n = 39 |
Contributor
Author
There was a problem hiding this comment.
Was already 34 exisitng TakeShell call sites, raised this just to ensure it doesnt break
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Restore main's Pixels border frame levels in EUI_CDM_Icons.lua - Migrate only entries that saved an actionSpellID to ability keys - Reuse scan tables and skip unrelated ACTIONBAR_SLOT_CHANGED rebinds - Decide Glow When Usable cooldown state inside the cooldown event - Drop the Cooldown State half of Glow When Visible (buff icons only) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How was it tested?
Screenshots
Buff Glow when Missing (Used Shield Block since BS is broken on Blizz CDM now)

Glow Action bar Config

Glowing Revenge + Execute when usable on Bars

Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames