Skip to content

fix: Forever WoW add Kick Tick support for Classes (Spell ranks etc..) - #2652

Merged
EllesmereGaming merged 1 commit into
EllesmereGaming:mainfrom
ericellb:fix/forever-interrupt-kicks
Oct 13, 2026
Merged

EllesmereGaming merged 1 commit into
EllesmereGaming:mainfrom
ericellb:fix/forever-interrupt-kicks

Conversation

@ericellb

@ericellb ericellb commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Fixes the cast bar "Interrupt on CD" colour never applying on WoW Forever (e.g. Shaman Earth Shock).
  • Adds a Forever-only kick table used instead of the retail one: Shield Bash, Pummel, Kick, Counterspell, Earth Shock, Silence, Feral Charge, all ranks.
  • Shield Bash (Battle/Defensive), Pummel (Berserker) and Feral Charge (Bear) only count while their stance or form is up; the kick re-resolves on UPDATE_SHAPESHIFT_FORM.
  • Retail is unchanged. The table is separate because some Classic ids are different spells on retail (16979 is Wild Charge, 8042 is a plain Earth Shock).

Notes

  • The Stance and Form checks means that the Tick will ONLY show up if you are in the proper form.
  • Otherwise could be confusing (however it does have value to see you can Feral Charge when not in form. Decided to keep out)

How was it tested?

  • Forever beta client, Warrior in Defensive stance: Shield Bash resolves and the cast bar tints.
  • Other classes and ranks are untested (no characters); their ids were checked to exist with C_Spell.GetSpellInfo only.
  • Guardrails (luac5.1) not run locally; relying on CI.

Screenshots

Interrupt working on Warrior (Did not work for Shield Bash before, so fix is confirmed)

cast-interrupt

Checklist

  • New settings default OFF (no behavior change without opt-in): N/A, no new settings
  • Zero cost while disabled: N/A, one Forever-only event registration
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames: N/A, read-only APIs
  • Tested in-game on live; no version gates or pre-Midnight APIs added: tested on the Forever beta only, not retail; the new code is gated on IS_FOREVER

…t works

Forever has no Wind Shear/Spell Lock-style retail kicks, so Shamans (and
Warriors, Rogues, Mages, Priests, Druids) never resolved an interrupt and the
cast bar never used the interrupt-on-cooldown colour.

Add a Forever-only kick table used instead of the retail one (several Classic
ids are different spells on retail). Ranks are grouped, and Shield Bash, Pummel
and Feral Charge only count in the stance or form they work in.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ericellb ericellb changed the title fix: Forever interrupts for the cast bar Interrupt on CD tint fix: Forever WoW add interrupt support for Classes (Spell ranks etc..) Oct 13, 2026
@ericellb ericellb changed the title fix: Forever WoW add interrupt support for Classes (Spell ranks etc..) fix: Forever WoW add Kick Tick support for Classes (Spell ranks etc..) Oct 13, 2026
@EllesmereGaming
EllesmereGaming merged commit 2231e20 into EllesmereGaming:main Oct 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants