Centralize PufferDrive Configuration and Evaluation Validation - #582
Open
Victorbares wants to merge 11 commits into
Open
Centralize PufferDrive Configuration and Evaluation Validation#582Victorbares wants to merge 11 commits into
Victorbares wants to merge 11 commits into
Conversation
- Removed unused imports and functions in evaluation_utils.py. - Simplified benchmark configuration loading by integrating validation functions. - Enhanced error handling for missing environment fields in benchmark configurations. - Updated benchmark argument building to include final validation and CLI overrides. - Improved test coverage for benchmark configuration validation, including edge cases. - Adjusted smoke tests to disable evaluators during runs. - Refined unit tests for configuration schema validation, ensuring robustness against invalid inputs.
Victorbares
changed the title
added 3 commits
September 1, 2026 11:34
…ne for training seed
… and backbone layer constraints
Victorbares
marked this pull request as ready for review
September 1, 2026 13:18
| "route": binding.GOAL_SOURCE_ROUTE, | ||
| "map": binding.GOAL_SOURCE_MAP, | ||
| "gt": binding.GOAL_SOURCE_GT, | ||
| }[goal_source] |
Collaborator
There was a problem hiding this comment.
unless I'm missing something, a wrong key won't talk anymore apart from the invalid dictionary key error? I prefer to have the error speak clearly about what's the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add structured schema validation for the complete PufferDrive configuration.
Validate field ranges, cross-field relationships, enums, and filesystem resources.
Apply validation consistently across training, evaluation, export, and benchmark configuration.
Refactor benchmark argument merging so CLI overrides are validated after all configuration sources
are combined.
Simplify redundant validation in the Python environment wrapper.
Expand unit and evaluation test coverage for invalid and merged configurations.
Why
Fail early with clear configuration errors before invalid values reach the simulator or training
loop. This also makes benchmark evaluation more reliable by validating the final resolved
configuration, including checkpoint settings, benchmark overlays, environment overrides, and CLI
arguments.