Implement basic stop logic - #586
Open
Victorbares wants to merge 5 commits into
Open
Conversation
Victorbares
force-pushed
the
vb/stop_logic
branch
from
September 3, 2026 08:01
681212b to
793fc66
Compare
Victorbares
marked this pull request as ready for review
September 3, 2026 08:27
vcharraut
reviewed
Sep 3, 2026
vcharraut
reviewed
Sep 3, 2026
vcharraut
reviewed
Sep 3, 2026
vcharraut
reviewed
Sep 3, 2026
Victorbares
marked this pull request as draft
September 3, 2026 08:35
added 3 commits
September 3, 2026 10:46
Victorbares
marked this pull request as ready for review
September 3, 2026 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds stop-sign compliance logic and rewards to the PufferDrive C engine:
timesteps within 5m of the stop line.
using Z_BUFFER.
reward penalties (sharing the reward_stop_line coefficient) to Python.
Why
false-positives on stacked/multi-level map geometries.
Notes