Skip to content

docs: update logo to new EpiAware design system icon - #159

Open
seabbs-bot wants to merge 3 commits into
mainfrom
chore/update-logo
Open

seabbs-bot wants to merge 3 commits into
mainfrom
chore/update-logo

Conversation

@seabbs-bot

Copy link
Copy Markdown
Collaborator

Replaces the package logo with the new icon from the EpiAware ecosystem's shared logo design system, unifying the visual identity across the *Distributions.jl family.

Only docs/src/assets/logo.svg changes; the README and VitePress config already reference that path, so no other updates are needed.

This was opened by a bot. Please ping @seabbs for any questions.

@github-actions

Copy link
Copy Markdown
Contributor

Try this Pull Request!

Option 1: Julia Package Manager

Open Julia and type:

import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/EpiAware/ModifiedDistributions.jl", rev="chore/update-logo")
using ModifiedDistributions

Option 2: Local Checkout

If you have the repo locally:

git checkout chore/update-logo
julia --project=. -e "using Pkg; Pkg.instantiate()"

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unit 97.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@seabbs-review-bot seabbs-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only swaps docs/src/assets/logo.svg for a new design (different palette, a hexagon outline, and a differently-shaped 'modified curve') with no code changes. The new markup dropped the accessible-name attributes (role, aria-label, title) the old SVG carried; otherwise the asset is self-contained and nothing in the repo tests or references its internal structure, so there's little else to review here.

Automated first pass by seabbs-review-bot (Claude sonnet), triggered by: first pass. Not a human review. @seabbs can comment @seabbs-review-bot to re-run it, or add the no-review label to opt this PR out. Ping @seabbs with any questions.

Comment thread docs/src/assets/logo.svg Outdated
<circle cx="174.57"
cy="142.95" r="5"
fill="#CB3C33" stroke="black" stroke-width="1"/>
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 400 440">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion The old SVG declared role="img", an aria-label, and a <title> giving the logo an accessible name. The new markup has none of these. The README wraps the file in an ..., so it's covered there, but DocumenterVitepress copies assets/logo into public/ for the site footer/nav, and if it's ever referenced without an alt on the wrapping element, the logo has no accessible name at all. Worth adding back, e.g.:

<title>ModifiedDistributions logo</title>

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: added role="img" aria-label="ModifiedDistributions.jl logo" to the <svg> tag and <title>ModifiedDistributions.jl logo</title> as its first child element. Verified the file still parses as well-formed XML.

@github-actions

Copy link
Copy Markdown
Contributor

📖 Documentation preview is ready!

View the docs for this PR at: https://EpiAware.github.io/ModifiedDistributions.jl/previews/PR159/

This preview will be updated automatically when you push new commits.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant