Repository navigation
docs: update logo to new EpiAware design system icon - #159
seabbs-bot wants to merge 3 commits into
Conversation
Try this Pull Request!Option 1: Julia Package ManagerOpen Julia and type: import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/EpiAware/ModifiedDistributions.jl", rev="chore/update-logo")
using ModifiedDistributionsOption 2: Local CheckoutIf you have the repo locally: git checkout chore/update-logo
julia --project=. -e "using Pkg; Pkg.instantiate()" |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
This PR only swaps docs/src/assets/logo.svg for a new design (different palette, a hexagon outline, and a differently-shaped 'modified curve') with no code changes. The new markup dropped the accessible-name attributes (role, aria-label, title) the old SVG carried; otherwise the asset is self-contained and nothing in the repo tests or references its internal structure, so there's little else to review here.
Automated first pass by seabbs-review-bot (Claude sonnet), triggered by: first pass. Not a human review. @seabbs can comment @seabbs-review-bot to re-run it, or add the no-review label to opt this PR out. Ping @seabbs with any questions.
| <circle cx="174.57" | ||
| cy="142.95" r="5" | ||
| fill="#CB3C33" stroke="black" stroke-width="1"/> | ||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 400 440"> |
There was a problem hiding this comment.
suggestion The old SVG declared role="img", an aria-label, and a <title> giving the logo an accessible name. The new markup has none of these. The README wraps the file in an , so it's covered there, but DocumenterVitepress copies assets/logo into public/ for the site footer/nav, and if it's ever referenced without an alt on the wrapping element, the logo has no accessible name at all. Worth adding back, e.g.:
There was a problem hiding this comment.
Fixed: added role="img" aria-label="ModifiedDistributions.jl logo" to the <svg> tag and <title>ModifiedDistributions.jl logo</title> as its first child element. Verified the file still parses as well-formed XML.
|
📖 Documentation preview is ready! View the docs for this PR at: https://EpiAware.github.io/ModifiedDistributions.jl/previews/PR159/ This preview will be updated automatically when you push new commits. |
Replaces the package logo with the new icon from the EpiAware ecosystem's shared logo design system, unifying the visual identity across the *Distributions.jl family.
Only
docs/src/assets/logo.svgchanges; the README and VitePress config already reference that path, so no other updates are needed.This was opened by a bot. Please ping @seabbs for any questions.