Repository navigation
fix: restore navbar/footer styling broken by the shared-chrome partials - #29
Merged
Merged
Conversation
PR #26 replaced the config-driven navbar/footer with static HTML partials injected via include-before-body/include-after-body, but the hand-rolled markup diverged from what Quarto's own navbar renderer produced, and the injection point turned out to sit inside <main> rather than at the body root: - navbar forced navbar-dark bg-dark, giving a dark bar even in light mode; theme-light.scss/theme-dark.scss already drive the navbar colours via $navbar-bg/$navbar-fg, so drop the hardcoded background. - the epinowcast forum link used bi-discord instead of bi-discourse, in both the navbar and the footer. - the navbar had no dark-mode toggle, so Quarto's fallback JS floated an unstyled toggle button in the top-right corner of the page. - website.search had no location/type, so Quarto defaulted to a sidebar textbox — rendered as a permanently-open input jammed into the navbar instead of the icon-triggered overlay a navbar location gets. - the footer used a generic Bootstrap row/col grid instead of Quarto's .nav-footer classes, losing the muted link colour and hairline border, and causing the per-page repo-actions injection (Edit this page/Report an issue) to append as a second, differently styled row instead of merging into the existing one. - header#quarto-header.fixed-top (to restore headroom hide-on-scroll) was tried and reverted: include-before-body content lands inside <main>, and <main> has its own CSS transform, which becomes the containing block for position:fixed descendants — that pinned the bar partway down the page and overlapped the title. position:sticky needs no such containing block and was already the right choice. Verified by rendering before/after and comparing screenshots.
📄 Site preview builtThe rendered site for this PR is available as the site-preview artifact on this run. Download it and open |
seabbs
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #26 (shared-chrome) moved the navbar/footer from Quarto's
config-driven
website.navbar/website.page-footerto static HTMLpartials injected via
include-before-body/include-after-body. Thehand-rolled markup diverged from what Quarto's own navbar renderer
used to produce, and the injection point turned out to land inside
<main>rather than at the body root, breaking several thingsvisually:
navbar-dark bg-dark) regardless of thesite's light/dark theme.
Discourse one, in both the navbar and footer.
an unstyled toggle button in the page's top-right corner.
navbar instead of the compact icon-triggered overlay, because
website.searchhad nolocation/typeto infer from..nav-footerclasses, losing the muted link colour/border, andcausing the per-page "Edit this page / Report an issue" injection
to append as a second, differently styled row.
This restores parity with the pre-#26 styling while keeping the
partials as the single source of truth shared with the tutorials
site.
Test plan
approaches/composed-distributions.qmdbefore (main)and after this change and compared screenshots — navbar/footer
now match the pre-feat: shared navbar/footer partials + Packages nav + add Sebastian Funk to team #26 design (light navbar, correct icons, dark
mode toggle, compact search, muted footer links, single merged
footer row).
real browser, including toggling dark mode
This was opened by a bot. Please ping @seabbs for any questions.