Skip to content

Introduce public API of rules_codechecker - #269

Open
nettle wants to merge 1 commit into
Ericsson:mainfrom
nettle:defs-aliases
Open

Introduce public API of rules_codechecker#269
nettle wants to merge 1 commit into
Ericsson:mainfrom
nettle:defs-aliases

Conversation

@nettle

@nettle nettle commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Why:
Users should not load rules from the implementation files under src/,
which exposes internals and deviates from the Bazel convention
of a single defs.bzl entry point per rules repository.

What:

  • Add defs.bzl exporting the user facing rules and macros
  • Switch README examples to @rules_codechecker//:defs.bzl
  • Switch unit and foss test BUILD files to the new load path
  • Keep clang_ctu_test and the internal codechecker rule in src/

@nettle
nettle requested review from Szelethus and furtib August 6, 2026 20:16
@furtib furtib added enhancement New feature or request non-functional change ☮️ The patch doesn't change any functionality, e.g. refactoring, documentation, test-only. labels Aug 7, 2026

@furtib furtib left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I don't know why CI hasn't run for this PR either; I will investigate.

Why:
Users should not load rules from the implementation files under src/,
which exposes internals and deviates from the Bazel convention
of a single defs.bzl entry point per rules repository.

What:
- Add defs.bzl exporting the user facing rules and macros
- Switch README examples to @rules_codechecker//:defs.bzl
- Switch unit and foss test BUILD files to the new load path
- Keep clang_ctu_test and the internal codechecker rule in src/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request non-functional change ☮️ The patch doesn't change any functionality, e.g. refactoring, documentation, test-only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants