Skip to content

Remove WORKSPACE files - #270

Merged
nettle merged 1 commit into
Ericsson:mainfrom
nettle:remove-workspace
Aug 7, 2026
Merged

Remove WORKSPACE files#270
nettle merged 1 commit into
Ericsson:mainfrom
nettle:remove-workspace

Conversation

@nettle

@nettle nettle commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Why:
Bazel 8 disables the WORKSPACE by default and Bazel 9 removed it.
Our WORKSPACE file is not used FOSS tests were skipped on Bazel 8,
which left yaml-cpp untested there.

What:

  • Delete WORKSPACE and test/foss/templates/WORKSPACE.template
  • Point the buildifier at MODULE.bazel
  • Remove zlib-module FOSS test
  • Convert yaml-cpp FOSS test to bzlmod, pin tag yaml-cpp-0.9.0
  • Drop the bazel 8 skip and the WORKSPACE handling from the FOSS tests
  • Document only the MODULE.bazel

@furtib furtib left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do not need to support WORKSPACE files, I'm all for this change!

Keep in mind that CI has not run for whatever reason!

I was hesitant to take this step due to Bazel 7 still supporting WORKSPACE files.
If we merge this don't forget to close: #258.

@nettle

nettle commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

If we do not need to support WORKSPACE files, I'm all for this change!

Keep in mind that CI has not run for whatever reason!

I was hesitant to take this step due to Bazel 7 still supporting WORKSPACE files. If we merge this don't forget to close: #258.

I think WORKSPACE support might be still important for Bazel 7,
but in this case we need a proper test!

@furtib, @Szelethus, please let me know if it is OK to merge since CI checks seem broken.

@nettle
nettle force-pushed the remove-workspace branch from 8b454b7 to f7be4ab Compare August 7, 2026 14:17
@nettle

nettle commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

... since CI checks seem broken.

CI checks were affected by GitHub incident (https://www.githubstatus.com/incidents/qcvjkzcs7j74) which is fixed now.
Checks were retriggered and passed.
Merging...

@nettle
nettle merged commit 648c670 into Ericsson:main Aug 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants