Use bazel's built in symlink instead of cp for config files - #273
Merged
Conversation
nettle
reviewed
Aug 10, 2026
nettle
left a comment
nettle
left a comment
Collaborator
There was a problem hiding this comment.
I guess this might be the best alternatives (among /usr/sbin/cp, no-remote, create file etc)!
The toughest question is the test...
furtib
force-pushed
the
use-symlink-instead-of-cp
branch
from
August 12, 2026 10:00
8a55d42 to
403b58b
Compare
Contributor
Author
|
Regarding tests, the existence of these config files is already covered by our test suite. |
Szelethus
approved these changes
Aug 12, 2026
Szelethus
left a comment
Szelethus
left a comment
Collaborator
There was a problem hiding this comment.
We already recieved word from a user who has a working BuildBarn instance, and this PR seems to fix the missing cp binary issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The
codechecker_configrule usescpto duplicate the user-provided config file. This is an unnecessary dependency oncp, and may not work correctly with remote executors.Using
ctx.actions.symlinkis the idiomatic Bazel approach, so it should work with remote execution and remote caching.What:
ctx.actions.run(executable = "cp", ...)call insrc/codechecker_config.bzlwithctx.actions.symlink(output, target_file).Addresses:
none