Add skylib analysis test for runfiles for the toolchain - #277
Open
furtib wants to merge 3 commits into
Open
Conversation
Szelethus
pushed a commit
that referenced
this pull request
Aug 13, 2026
Why: We want the toolchain to be correct. What: - Fixed the wrong default value for CodeChecker. - Removed `allow_single_file = True` from each target. This attribute prevents users from using `sh_binary` or similar targets to provide their tools. (This is why I needed a mock rule for my test in #277.) Addresses: none
furtib
force-pushed
the
test_toolchain_runfiles
branch
from
August 13, 2026 09:35
5172c44 to
dab2af3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want a test case for #274.
What:
Addresses:
none