Skip to content

Move buildifier to test/ - #289

Merged
furtib merged 1 commit into
Ericsson:mainfrom
nettle:buildifier-test
Aug 14, 2026
Merged

Move buildifier to test/#289
furtib merged 1 commit into
Ericsson:mainfrom
nettle:buildifier-test

Conversation

@nettle

@nettle nettle commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Why:
buildifier_prebuilt is a dev dependency, therefore it is not visible to
the users while the root package has to stay loadable by them.
A lint test also belongs the tests rather than in the root package.

What:

  • Move buildifier_test and its patches to test/buildifier
  • Export MODULE.bazel to the linter package, it is the workspace marker
  • Point the buildifier_prebuilt patches to the new location
  • Run //test/buildifier in the lint step of the workflow

@nettle
nettle requested a review from furtib August 13, 2026 20:24
@nettle nettle mentioned this pull request Aug 13, 2026

@furtib furtib left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@furtib
furtib merged commit bed72c8 into Ericsson:main Aug 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants