Repository navigation
fix(ce-code-review): bind finish workers to the reviewed checkout - #1845
Open
arimetabot wants to merge 1 commit into
Open
arimetabot wants to merge 1 commit into
arimetabot wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fresh review workers now receive the checkout that produced the diff instead of relying on their inherited working directory. This prevents a same-branch, same-HEAD checkout with different staged changes from being treated as the reviewed tree.
The binding is captured during scope collection and checked by finish leaves and validators. The index is fingerprinted separately because an unstaged edit can cancel a staged change in the working-tree diff. Remote reviews retain their existing reviewed-ref rules; local apply authority is unchanged.
Fixes #1844.
Validation
No installed plugin or host configuration was changed. No claim is made about time or token savings.
Security Disclosure
This changes checkout-path and state-validation instructions. Missing or mismatched local bindings stop finish or leave validation unresolved. The checks assume a trusted, cooperative checkout; they are not a sandbox and do not prevent concurrent changes between verification and use. No dependencies, credentials, permissions, or external-provider routes changed.
Agent Disclosure