fix(aws_s3 source): delete SQS messages that cannot be parsed - #48
Merged
Merged
Conversation
A message that fails to parse as an S3 notification fails identically on every redelivery, but was never deleted: the parse error returned before the delete, so SQS kept making the message visible until the retention period expired, growing the queue and competing with valid messages sharing it. Queue these messages for deletion after emitting the same parse error as before, so an unrecognized message shape does not silently disappear.
pupapaik
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A message that fails to parse as an S3 notification fails identically on every redelivery, but was never deleted: the parse error returned before the delete, so SQS kept making the message visible until the retention period expired, growing the queue and competing with valid messages sharing it.
Queue these messages for deletion after emitting the same parse error as before, so an unrecognized message shape does not silently disappear.