Repository navigation
fix(report): respect auto-zoom toggle for earthquake reports - #34
Merged
Merged
Conversation
Platform: all Fix(zh-Hant): 地震報告會正確套用自動縮放設定，關閉後返回預設地圖範圍 Fix(en-US): earthquake reports now respect the auto-zoom setting and restore the default map view when disabled
lowrt
previously approved these changes
Oct 15, 2026
whes1015
previously approved these changes
Oct 26, 2026
whes1015
left a comment
whes1015
left a comment
Member
There was a problem hiding this comment.
看過 diff，方向正確：fitReport() 在自動縮放關閉時直接 return，focus 的設定變更也會把視角帶回台灣預設範圍，關閉→開啟兩種方向都補到了。2 個檔案、+24/−2，沒動到其他行為。
一個小建議（不擋合併）：report.ts 那個 onConfigUpdated 少了 isAutoFocusLocked() 的檢查。這個檔其他呼叫 fitReport() 的地方（第 224 行）都有先擋手動鎖定，只有新加的這條沒有，所以使用者自己拖過地圖（鎖定中）再改音量或 TTS，地圖會被拉回地震報告。之後如果要收緊，加上 if (isAutoFocusLocked()) return; 或只比較 graphics-block-auto-zoom 這個鍵有沒有變就好。
Platform: all Fix(zh-Hant): 調整音量或其他設定時，地圖不會再被拉回地震報告 Fix(en-US): changing the volume or any other setting no longer pulls the map back to the earthquake report
whes1015
approved these changes
Oct 26, 2026
whes1015
left a comment
whes1015
left a comment
Member
There was a problem hiding this comment.
CI 全過（14 項），第二個 commit 只收斂 onConfigUpdated 的觸發條件，行為與 focus.ts 一致，可以合。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform: all
Fix(zh-Hant): 地震報告會正確套用自動縮放設定，關閉後返回預設地圖範圍
Fix(en-US): earthquake reports now respect the auto-zoom setting and restore the default map view when disabled