fix: open country selector RHP when adding a personal card after upgrade#96752
Open
dilshodmackbook-sketch wants to merge 2 commits into
Open
Conversation
…fter upgrade The upgrade confirmation "Add personal card" button only closed the RHP (leaving a TODO), which popped the whole RHP stack back to the Wallet page. Navigate directly to the add-card route within the already-open RHP using forceReplace so the country selector opens smoothly with no close/re-open flicker, and back returns to the Wallet page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
7 tasks
…tive) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dilshodmackbook-sketch
marked this pull request as ready for review
July 22, 2026 20:02
melvin-bot
Bot
requested review from
joekaufmanexpensify and
situchan
and removed request for
a team
July 22, 2026 20:02
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
joekaufmanexpensify
approved these changes
Jul 23, 2026
joekaufmanexpensify
left a comment
Contributor
There was a problem hiding this comment.
Good for product 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
After creating a workspace from the "Add personal card" upgrade flow, tapping Add personal card on the confirmation screen only closed the RHP (the real navigation was left as a
TODO). Because the upgrade page was the only route in the RHP stack,closeRHPFlow()popped the whole RHP and dropped the user back on the Wallet page instead of opening the country selector.This navigates directly to the add-card route from within the already-open RHP using
forceReplace, so the country selector (AddNewCardPage, which defaults to the country-selector step) opens smoothly in the same RHP with no close/re-open flicker. Both screens are siblings in the Settings RHP stack, so there is no need to tear down the RHP.forceReplaceswaps out the completed upgrade confirmation rather than pushing on top of it, so pressing back from the country selector returns to the Wallet page as expected.Fixed Issues
$ #94429
PROPOSAL: #94429 (comment)
Tests
Offline tests
Same as the Tests above — the navigation change is purely client-side, so the country selector RHP opens the same way while offline.
QA Steps
Same as the Tests above.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-07-23.at.00.27.52.mov
Android: mWeb Chrome
Screen.Recording.2026-07-23.at.00.01.48.mov
iOS: Native
Screen.Recording.2026-07-23.at.00.38.32.mov
iOS: mWeb Safari
Screen.Recording.2026-07-23.at.00.02.55.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-22.at.23.58.32.mov
Screen.Recording.2026-07-23.at.00.00.26.mov