Skip to content

Add the first test audit, and tests for two cases it found untested - #3

Merged
mgilardi merged 1 commit into
mainfrom
test-audit
Nov 10, 2026
Merged

mgilardi merged 1 commit into
mainfrom
test-audit

Conversation

@mgilardi

Copy link
Copy Markdown
Contributor

First test audit (docs/test-audit.md).

  • New GriefPreventionClaimsTest (5 tests): claims that can't be read mean nobody is moved. The code moved into fromDataStore; behavior is unchanged.
  • New bot checks: only XP, or only an ender-chest item, counts as an existing player. The existing-players section passes 9/9 on Paper 26.1.2; the full suite was not rerun.

🤖 Generated with Claude Code

The audit maps each promise to its tests. Two gaps:
- If GriefPrevention's claims can't be read, every spot counts as near a
  claim, so nobody is moved. The code did this; nothing tested it. The
  part after finding the data store moves into fromDataStore (behavior
  unchanged), and GriefPreventionClaimsTest covers it: 5 tests, with a
  positive control.
- skip-existing-players also counts only XP, or only an ender-chest item.
  Two bot checks added; the existing-players section passed 9/9 on Paper
  26.1.2. The full suite wasn't rerun.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mgilardi
mgilardi merged commit ae3d292 into main Nov 10, 2026
2 checks passed
@mgilardi
mgilardi deleted the test-audit branch November 10, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant