Skip to content

fuzz: keep the fuzz corpus from one scheduled run to the next #862

Open

Description

@LeeroyHannigan

What is wrong

Each Fuzz run starts from the committed seeds in fuzz/seeds and discards the corpus it builds. @robinnsc found on #798 that five of the six targets were still finding new coverage in the last second of the 60-second pull request run (comment). The 600-second daily run starts from the same seeds each day, so most of each run covers the same inputs as the run before.

Where

  • .github/workflows/fuzz.yml
  • fuzz/seeds/

What to change

Two options:

  1. An Actions cache of the corpus that only the scheduled job writes, and that pull request runs do not restore. The Fuzz workflow uses no cache, and the release workflows leave the Actions cache out on purpose because of the CodeQL cache-poisoning query. A pull request workflow can restore a cache that a run on main wrote, so any pull request could read the cached corpus.
  2. A corpus that a maintainer minimizes with cargo fuzz cmin and commits to fuzz/seeds at intervals, in a pull request that gets the same review as any other change.

Recommendation

Option 2. The workflow stays free of caches, and a reviewer sees each change to the corpus.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions