Skip to content

test: let Cassandra suites use a configurable contact point #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dodothereal wants to merge 4 commits into
base: main
Choose a base branch
from
+11 −7
Open

test: let Cassandra suites use a configurable contact point #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a0c302
test: let Cassandra suites use a configurable contact point
Dodothereal Oct 25, 2026
0299470
test: address Cassandra contact-point review feedback
Dodothereal Oct 28, 2026
9ed4faf
Merge branch 'upstream/main' into issue-580-cassandra-test-contact-point
Dodothereal Nov 6, 2026
335869b
Merge branch 'main' into issue-580-cassandra-test-contact-point
LeeroyHannigan Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/storage-cassandra/tests/direct_integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
//! Direct storage-trait integration tests, ported from the original
//! extenddb-cassandra-plugin repository (its tests/rust suite). They exercise
//! the Cassandra engine's trait implementations directly against a live node
//! at 127.0.0.1:9042 — no HTTP server in between — and skip themselves when
//! no Cassandra is reachable (see helpers::skip_without_cassandra).
//! at the contact point in `EXTENDDB_TEST_CASSANDRA_CONTACT_POINT` (default
//! 127.0.0.1:9042) — no HTTP server in between — and skip themselves when no
//! Cassandra is reachable (see helpers::skip_without_cassandra).
//!
//! One binary, one module per area, sharing tests/common/mod.rs, which is the
//! in-tree descendant of the plug-in repo's helpers.rs.
Expand Down
5 changes: 3 additions & 2 deletions crates/storage-cassandra/tests/ttl_integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@

//! Integration tests for Cassandra TTL against a live Cassandra.
//!
//! Requires Cassandra on 127.0.0.1:9042. There is no Cassandra CI workflow, so
//! these are run locally.
//! Requires Cassandra at the contact point in
//! `EXTENDDB_TEST_CASSANDRA_CONTACT_POINT` (default 127.0.0.1:9042). The
//! integration-cassandra workflow runs these against a service container.

#[path = "common/mod.rs"]
mod helpers;
Expand Down
8 changes: 5 additions & 3 deletions devtools/run-cassandra-tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,10 @@
#
# Prerequisites:
# - A Cassandra node reachable at the contact point (default 127.0.0.1:9042)
# with PasswordAuthenticator enabled. The official cassandra:4.1 image does
# not honour CASSANDRA_AUTHENTICATOR, so patch it after starting:
# with PasswordAuthenticator enabled. The Rust direct tests read
# EXTENDDB_TEST_CASSANDRA_CONTACT_POINT (default 127.0.0.1:9042), which
# --contact-points above doesn't set. The official cassandra:4.1 image
# does not honour CASSANDRA_AUTHENTICATOR, so patch it after starting:
# docker run -d --name cassandra -p 127.0.0.1:9042:9042 \
# -e CASSANDRA_CLUSTER_NAME=extenddb-ci \
# -e HEAP_NEWSIZE=128M -e MAX_HEAP_SIZE=1024M \
Expand Down Expand Up @@ -67,7 +69,7 @@ while [[ $# -gt 0 ]]; do
--output) OUTPUT_DIR="$2"; shift 2 ;;
--keep) KEEP=true; shift ;;
--) shift; RUN_TESTS_ARGS=("$@"); break ;;
-h|--help) sed -n '5,35p' "$0" | sed 's/^# \{0,1\}//'; exit 0 ;;
-h|--help) sed -n '5,47p' "$0" | sed 's/^# \{0,1\}//'; exit 0 ;;
*) echo "error: unknown option: $1" >&2; exit 1 ;;
esac
done
Expand Down