Repository navigation
ci(sync-fork): sync by repository URL with the dedicated sync-fork key - #747
Merged
Merged
Conversation
Pin @osaas/cli to 4.35.0 and call admin sync-fork with --repository-url, which skips the catalog lookup that the dedicated key cannot make. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review — LGTM
Automated review (daily-backlog-pr Phase 3.5, orphan PR). Small, self-contained CI change to .github/workflows/sync-fork.yml: pins @osaas/cli@4.35.0 (aligns with the dependency policy's prefer-pinned-versions rule) and switches the sync-fork trigger from a positional service name to --repository-url <repo>. Uses the existing OSC_API_KEY secret; no new secret, no app-code impact. CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@osaas/clito 4.35.0 and runosc admin sync-fork --repository-url https://github.com/Eyevinn/intercom-frontendinstead of passing the serviceId.--repository-urlskips the catalog lookup (GET catalog.svc.<env>.osaas.io/service/<serviceId>). Since the 2026-10-27 prod API key rotation that lookup can fail withinvalid authorization header, and the CLI still exits 0, so runs look green without syncing.Lessons
The CLI exits 0 when the catalog lookup fails, so a green "Sync OSC Fork" run proves nothing; check the log for
Sync fork status. Same change as Eyevinn/open-live#616 and Eyevinn/open-live-studio#253.What a human does next
OSC_API_KEYin this repo works with either the platform key or the dedicated sync-fork key, because the new calls are accepted for both. After merging, run "Sync OSC Fork" for prod once and confirm the log showsSync fork status: succeeded.🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 5.5 noreply@anthropic.com