Repository navigation
fix: preserve equals signs in merged environment values - #559
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
Split environment assignments at the first equals sign so config merges and extends keep complete values. Cover global and process overrides, inheritance, empty values and parent preservation.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Fixes #554.
Config merging drops values such as A=a=b and padded base64 strings. Splitting assignments at the first equals sign preserves the full value for config overrides and extends.
The regressions cover global and process environments, overrides and parent preservation. All three cases fail on the original code.
make build, make testrace and make lint pass on Linux with Go 1.26.6. Seven compiled CLI cases also pass, including both file orders and inherited overrides. Nix isn't installed here, so I haven't run the Nix build.