Repository navigation
Feature/custom field select mapping - #102
Merged
Merged
Conversation
Resolve labels to FOLIO option ids for single-select, multi-select, and radio-button custom fields on user import, falling back to raw option ids and degrading gracefully if the custom-fields definitions can't be fetched. Also converts several UserImporter methods that had no actual async work to plain sync defs, per SonarQube's unnecessary-async flags.
UserImporter.build_custom_field_option_maps used to hit /custom-fields via a hand-rolled pagination loop against folio_client.httpx_client directly, which could raise "Cannot send a request, as the client has been closed." if an earlier folio_get_all call left the shared client closed. Delegate to folioclient's own folio_get_all (>=1.0.13), which now accepts a headers kwarg and already handles session self-healing and pagination, removing the need for our own reimplementation. Add a live-environment integration test (tests/test_user_import_integration.py, gated behind the `integration` marker and FOLIO_* env vars) that provisions a real select-type custom field definition and validates label resolution and user creation end-to-end against a live FOLIO snapshot tenant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for mapping mapping select custom fields from friendly values in UserImporter, and bump version for release.