Enforce per-account rate limit for new developer profile creation - #184
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
api | 07bae9e | Commit Preview URL Branch Preview URL |
Aug 05 2026, 06:12 AM |
…ct-policy-for-profile-creation # Conflicts: # src/services/extensions/v2/index.ts # worker-configuration.d.ts
admdly
marked this pull request as ready for review
August 5, 2026 06:00
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Requires human review: Introduces a new per-account rate limit with threshold (3 per 60s) and a new Cloudflare binding. The operational tradeoff of these parameters requires human review to confirm appropriateness.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
allowCreationAttemptcallback parameter toDevelopersDatabase.upsertOwnthat is consulted only when creating a brand-new profile and return error codePROFILE_CREATION_RATE_LIMITEDwhen disallowed.c.env.PROFILE_CREATION_RATE_LIMITER.limit({ key: auth.userId }), mapPROFILE_CREATION_RATE_LIMITEDto HTTP429, and set aRetry-After: 60header on that response.429and add thePROFILE_CREATION_RATE_LIMITERbinding toworker-configuration.d.tsas well as aratelimitsentry inwrangler.jsonc.freshProfileCreationRateLimiter()and two tests totest/services/extensions/v2/index.test.tsthat verify per-account creation limits and that profile updates do not consume creation allowance.