Skip to content

refactor: one home for the rotation head read and a bounded hourly enrolment walk #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FSM1 merged 3 commits into from
Sep 15, 2026
Merged

refactor: one home for the rotation head read and a bounded hourly enrolment walk #1848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08e3d01
refactor(engine): give the record-head read and the keyless-root rule…
FSM1 Sep 14, 2026
90cd6f2
perf(engine): stop the hourly scope-pointer enrolment walk after one …
FSM1 Sep 14, 2026
3c5af96
fix(engine): keep the enrolment walk latched after a terminal trust r…
FSM1 Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion crates/engine/src/facade.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5794,8 +5794,12 @@ where {
let http = self.seams.http.clone();
let entropy = self.entropy.clone();
let pointer_keys = self.sweep_keys.clone();
let scope_read_seeds = self.scope_read_seeds.clone();
let scope_write_seeds = self.scope_write_seeds.clone();
let root_id = self.snapshot.borrow().root.0;
self.seams.scheduler.spawn(Box::pin(async move {
// One latch per session: the loop is spawned once per start.
let scope_tree_walked = Cell::new(false);
run_liveness_loop(&scheduler, RE_PUT_INTERVAL, || async {
if !alive.get() {
return LivenessControl::Stop;
Expand All @@ -5808,7 +5812,7 @@ where {
// or the pointer lapses at its EOL.
let session_keys = pointer_keys.borrow().clone();
if let Some(keys) = session_keys {
enrol_owned_scope_pointers(ScopePointerEnrolment {
let consulted = enrol_owned_scope_pointers(ScopePointerEnrolment {
api: &api,
transport: &transport,
gateway: &gateway,
Expand All @@ -5825,8 +5829,21 @@ where {
held: &held,
root_id,
payload_version: POINTER_PAYLOAD_VERSION,
walked: &scope_tree_walked,
})
.await;
// The consult advances a sighted scope's write-epoch floor,
// so the seed cells it retires are evicted here, exactly as
// the focus tick evicts them around its own consult.
for scope_id in consulted {
refresh_seed_floors(
&floors,
&scope_id,
&scope_read_seeds,
&scope_write_seeds,
)
.await;
}
}
let records: Vec<HeldRecord> = held
.borrow()
Expand Down
Loading