chore(deps): remove unused @canton-network/wallet-sdk direct dependency - #420
Merged
Merged
Conversation
Repo audit found no imports of @canton-network/wallet-sdk anywhere in src/, test/, scripts/, examples/, docs, or configs. The package serves wallet provider/exchange integration and signing/submission use cases upstream, but this SDK does not exercise them: the identifier '@canton-network' appears only in this dependency declaration, and published artifacts are limited to build/src/**, so no public export or package artifact can reference it. Removal verified with a full build (tsc7 core + lint projects, after initializing the libs/splice submodule), all 82 unit test suites (1163 tests), npm-package-json-lint, and the package-artifact check. A residual @canton-network/wallet-sdk@1.4.0 remains in node_modules via the @fairmint/canton-dev-tools devDependency chain, which is expected and out of scope for this change. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Repository-wide searches confirm no direct references remain.
Review effort: Balanced
Findings: None
What changed in this PR
Removes an unused direct Wallet SDK dependency, reducing the SDK’s runtime dependency surface.
Changes:
- Removes
@canton-network/wallet-sdkfrom root dependencies. - Preserves indirect usage through development tooling.
| File | Description |
|---|---|
package.json |
Removes the unused direct dependency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the direct dependency
@canton-network/wallet-sdk(pinned1.5.1) from rootpackage.json. Upstream Wallet SDK serves wallet provider/exchange integration and signing/submission use cases, but this SDK does not exercise any of them — a full audit found the scope identifier@canton-networkappears only in the dependency declaration itself, nowhere insrc/,test/,scripts/,examples/, docs, or configs. Since any JS/TS usage requires the literal package specifier, its absence across every file (tracked and untracked) proves absence of usage — not just of imports.Verification performed before removal
wallet-sdk,wallet_sdk,walletSdk,WalletSdk,WalletSDK, and the whole@canton-networkscope → onlypackage.jsonmatched.build/src/**; with nosrc/import, no public export can reference the package.check:package-artifactspasses (1403 files, 5.86 MB, unchanged surface).@canton-network/wallet-sdk..cjsfiles or dynamicrequire()paths that could reference it.Checks
npm install(fresh, without the dep) — 971 packages installed successfullynpm run build(tsc7 core + lint projects, after initializing thelibs/splicesubmodule) — ✅jestwithtest/integrationexcluded; plainnpm testincludes LocalNet integration tests that require a running LocalNet — environment-only failures confirmed identical with the dependency still present)npm run lint:npm:check— ✅npm run check:package-artifacts— ✅Notes
package-lock.jsonis intentionally not committed (gitignored per repo convention).@canton-network/wallet-sdk@1.4.0remains innode_modulesvia the@fairmint/canton-dev-tools@0.1.7devDependency chain — expected, and not part of this SDK's own dependency graph.origin/main(verified via stash/restore, identical without this change): 4 ESLint errors insrc/utils/external-signing/*+ its unit tests, and 36 files failing Prettier. Untouched here to keep the PR focused; can be a follow-up.🤖 Generated with Claude Code
Made with Cursor